chrome/browser/ui/webui/options/extension_settings_handler.cc - Issue 8469015: Switch BackgroundContents to use TabContents instead of RenderViewHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/extension_settings_handler.cc

Issue 8469015: Switch BackgroundContents to use TabContents instead of RenderViewHost. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix unittest Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/extension_settings_handler.cc

===================================================================

--- chrome/browser/ui/webui/options/extension_settings_handler.cc (revision 109469)

+++ chrome/browser/ui/webui/options/extension_settings_handler.cc (working copy)

@@ -616,8 +616,8 @@

MaybeUpdateAfterNotification();

break;

case chrome::NOTIFICATION_BACKGROUND_CONTENTS_DELETED:

- deleting_rvh_ =

- content::Details<BackgroundContents>(details)->render_view_host();

+ deleting_rvh_ = content::Details<BackgroundContents>(details)->

+ tab_contents()->render_view_host();

// Fall through.

case chrome::NOTIFICATION_BACKGROUND_CONTENTS_NAVIGATED:

case chrome::NOTIFICATION_EXTENSION_HOST_CREATED: