Refactor proxy handling for ChromeOS to not go through the CrosSettings interface.

chrome/browser/chromeos/proxy_config_service_impl.cc

Index: chrome/browser/chromeos/proxy_config_service_impl.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl.cc b/chrome/browser/chromeos/proxy_config_service_impl.cc
index 7d18ba4d0797e976f8766dd6517d9b1053e8679a..405bfaf574f97810783c50caed1c6c6247acdf64 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl.cc
@@ -753,6 +753,11 @@ void ProxyConfigServiceImpl::DetermineEffectiveConfig(const Network* network,
     else
       current_ui_config_.user_modifiable = !network || !IgnoreProxy(network);
   }
+  // Notify whoever is interested in this change.

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

I still think an actual observer or callback-based solution would be more
appropriate in this case.

+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_CURRENT_NETWORK_CHANGED,
+      content::NotificationService::AllSources(),
+      content::NotificationService::NoDetails());

[kuan, 2011/11/08 14:45:25]

this is the wrong place to fire this notification; it shld be done in
OnUISetCurrentNetwork (i.e. the fn right below).
DetermineEffectiveConfig (where u're doing it now) is called not just for ui
changes, whereas OnUISetCurrentNetwork is only called for ui changes.

 }
 
 void ProxyConfigServiceImpl::OnUISetCurrentNetwork(const Network* network) {