Refactor proxy handling for ChromeOS to not go through the CrosSettings interface.

chrome/browser/chromeos/proxy_config_service_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/proxy_config_service_impl.h"
 
 #include <ostream>
 
 #include "base/bind.h"
 #include "base/json/json_value_serializer.h"
@@ skipping 735 matching lines @@
       }
     }
   } else {  // For UI, store effective proxy into |current_ui_config_|.
     current_ui_config_.FromNetProxyConfig(effective_config);
     current_ui_config_.state = effective_config_state;
     if (PrefPrecedes(effective_config_state))
       current_ui_config_.user_modifiable = false;
     else
       current_ui_config_.user_modifiable = !network || !IgnoreProxy(network);
   }
+  // Notify whoever is interested in this change.

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

I still think an actual observer or callback-based solution would be more
appropriate in this case.

+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_CURRENT_NETWORK_CHANGED,
+      content::NotificationService::AllSources(),
+      content::NotificationService::NoDetails());

[kuan, 2011/11/08 14:45:25]

this is the wrong place to fire this notification; it shld be done in
OnUISetCurrentNetwork (i.e. the fn right below).
DetermineEffectiveConfig (where u're doing it now) is called not just for ui
changes, whereas OnUISetCurrentNetwork is only called for ui changes.

 }
 
 void ProxyConfigServiceImpl::OnUISetCurrentNetwork(const Network* network) {
   DetermineEffectiveConfig(network, false);
   VLOG(1) << this << ": current ui network: "
                   << (network->name().empty() ?
                       current_ui_network_ : network->name())
                   << ", " << ModeToString(current_ui_config_.mode)
                   << ", " << ConfigStateToString(current_ui_config_.state)
                   << ", modifiable:" << current_ui_config_.user_modifiable;
 }
 
 void ProxyConfigServiceImpl::ResetUICache() {
   current_ui_network_.clear();
   current_ui_config_ = ProxyConfig();
 }
 
 }  // namespace chromeos