Refactor proxy handling for ChromeOS to not go through the CrosSettings interface.

chrome/browser/chromeos/proxy_cros_settings_parser.h

Index: chrome/browser/chromeos/proxy_cros_settings_parser.h
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.h b/chrome/browser/chromeos/proxy_cros_settings_parser.h
new file mode 100644
index 0000000000000000000000000000000000000000..eb9314e9e902b2a95d3b293a631b8dfaa29be0cf
--- /dev/null
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.h
@@ -0,0 +1,51 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_PROXY_CROS_SETTINGS_PARSER_H_
+#define CHROME_BROWSER_CHROMEOS_PROXY_CROS_SETTINGS_PARSER_H_
+#pragma once

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

#include <string>

[pastarmovj, 2011/11/09 17:51:53]

Done.

+
+#include "base/values.h"

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

forward declaration would suffice.

[pastarmovj, 2011/11/09 17:51:53]

Done.

+#include "chrome/browser/chromeos/proxy_config_service_impl.h"

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

don't need this?

[pastarmovj, 2011/11/09 17:51:53]

Done. I need it in the cc only.

+
+class Profile;
+
+namespace chromeos {
+
+extern const char kProxyPacUrl[];
+extern const char kProxySingleHttp[];
+extern const char kProxySingleHttpPort[];
+extern const char kProxyHttpUrl[];
+extern const char kProxyHttpPort[];
+extern const char kProxyHttpsUrl[];
+extern const char kProxyHttpsPort[];
+extern const char kProxyType[];
+extern const char kProxySingle[];
+extern const char kProxyFtpUrl[];
+extern const char kProxyFtpPort[];
+extern const char kProxySocks[];
+extern const char kProxySocksPort[];
+extern const char kProxyIgnoreList[];
+

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

Class description.

[pastarmovj, 2011/11/09 17:51:53]

Done.

+class ProxyCrosSettingsParser {
+ public:
+  // Sets a value in the current proxy configuration on the specified profile.
+  static void SetProxyPrefValue(Profile* profile,
+                                const std::string& path,
+                                const base::Value* in_value);

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

newline

[pastarmovj, 2011/11/09 17:51:53]

Done.

+  // Gets a value from the current proxy configuration on the specified profile.
+  static bool GetProxyPrefValue(Profile* profile,
+                                const std::string& path,
+                                base::Value** out_value);
+
+ private:
+  // We should never need objects of this class it is meant only to provide its
+  // helper functions.

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

Make it a namespace then?

[pastarmovj, 2011/11/09 17:51:53]

Done.

+  explicit ProxyCrosSettingsParser();

[Mattias Nissler (ping if slow), 2011/11/08 09:25:22]

newline

+  DISALLOW_COPY_AND_ASSIGN(ProxyCrosSettingsParser);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_PROXY_CROS_SETTINGS_PARSER_H_