Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8463018: Use ScopedMakeCurrent (Closed)

Created:
9 years, 1 month ago by jonathan.backer
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

Use ScopedMakeCurrent Then we don't have to think about switching contexts on the display path. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109667

Patch Set 1 : "" #

Total comments: 2

Patch Set 2 : Address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M content/browser/renderer_host/accelerated_surface_container_linux_cc.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_client.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M ui/gfx/compositor/compositor.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/gfx/compositor/compositor_cc.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/compositor/compositor_cc.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jonathan.backer
piman for review ben for OWNERS
9 years, 1 month ago (2011-11-11 16:36:32 UTC) #1
piman
http://codereview.chromium.org/8463018/diff/2002/ui/gfx/compositor/compositor_cc.cc File ui/gfx/compositor/compositor_cc.cc (right): http://codereview.chromium.org/8463018/diff/2002/ui/gfx/compositor/compositor_cc.cc#newcode86 ui/gfx/compositor/compositor_cc.cc:86: if (initialized_) nit: Please keep the DCHECK here. ScopedResourcesCC ...
9 years, 1 month ago (2011-11-11 17:35:30 UTC) #2
jonathan.backer
http://codereview.chromium.org/8463018/diff/2002/ui/gfx/compositor/compositor_cc.cc File ui/gfx/compositor/compositor_cc.cc (right): http://codereview.chromium.org/8463018/diff/2002/ui/gfx/compositor/compositor_cc.cc#newcode86 ui/gfx/compositor/compositor_cc.cc:86: if (initialized_) On 2011/11/11 17:35:31, piman wrote: > nit: ...
9 years, 1 month ago (2011-11-11 18:12:48 UTC) #3
piman
lgtm
9 years, 1 month ago (2011-11-11 18:22:39 UTC) #4
Ben Goodger (Google)
9 years, 1 month ago (2011-11-11 18:45:26 UTC) #5 
LGTM2

On Fri, Nov 11, 2011 at 10:22 AM, <piman@chromium.org> wrote:

> lgtm
>
>
>
>
http://codereview.chromium.**org/8463018/<http://codereview.chromium.org/8463...
>

Powered by Google App Engine
This is Rietveld 408576698