More surgery to remove views desktop.

More surgery to remove views desktop.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111192

[sky, 2011-11-21 18:10:32]

http://codereview.chromium.org/8461017/diff/1/chrome/browser/ui/touch/sensors...
File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):

http://codereview.chromium.org/8461017/diff/1/chrome/browser/ui/touch/sensors...
chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:49: #if
defined(USE_AURA)
Should this ifdef be removed too?

[Ian Vollick, 2011-11-21 20:00:44]

On 2011/11/21 18:10:32, sky wrote:
>
http://codereview.chromium.org/8461017/diff/1/chrome/browser/ui/touch/sensors...
> File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):
> 
>
http://codereview.chromium.org/8461017/diff/1/chrome/browser/ui/touch/sensors...
> chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:49: #if
> defined(USE_AURA)
> Should this ifdef be removed too?

Yes, this is really an aura-specific class now. And now that it's aura-only it
made sense to get rid of browser_parts_touch and put the initialization into
browser_parts_aura. This removes more TOUCH_UI ifdef's, too, which is nice.
Since we don't care about orientation at the moment, the listener won't do
anything and shouldn't affect anyone, but if it's ready to go whenever we start
caring about orientation again.

[sadrul, 2011-11-21 20:16:01]

http://codereview.chromium.org/8461017/diff/6001/chrome/browser/ui/touch/sens...
File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):

http://codereview.chromium.org/8461017/diff/6001/chrome/browser/ui/touch/sens...
chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:48: if
(aura_desktop) {
Remove this since the aura desktop is initialized before
ScreenOrientationListener.

[Ian Vollick, 2011-11-21 20:27:41]

On 2011/11/21 20:16:01, sadrul wrote:
>
http://codereview.chromium.org/8461017/diff/6001/chrome/browser/ui/touch/sens...
> File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):
> 
>
http://codereview.chromium.org/8461017/diff/6001/chrome/browser/ui/touch/sens...
> chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:48: if
> (aura_desktop) {
> Remove this since the aura desktop is initialized before
> ScreenOrientationListener.

Done. Also added a comment to explain this.

[sky, 2011-11-21 21:43:06]

LGTM

http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):

http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:14: #include
"ui/aura/desktop.h"
nit: sort

[Ian Vollick, 2011-11-22 15:45:44]

The rebase was trickier than I'd hoped. The browser parts code has been moved
around and the orientation listener has been moved from ui/touch/sensors to
ui/sensors since it has nothing to do with touch.

sky@, are you ok with the new home for the listener?

On 2011/11/21 21:43:06, sky wrote:
> LGTM
> 
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):
> 
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:14: #include
> "ui/aura/desktop.h"
> nit: sort

Done.

[sky, 2011-11-22 16:35:31]

Since the code uses aura it should live in chrome/browser/ui/views/aura

  -Scott

On 2011/11/22 15:45:44, vollick wrote:
> The rebase was trickier than I'd hoped. The browser parts code has been moved
> around and the orientation listener has been moved from ui/touch/sensors to
> ui/sensors since it has nothing to do with touch.
> 
> sky@, are you ok with the new home for the listener?
> 
> On 2011/11/21 21:43:06, sky wrote:
> > LGTM
> > 
> >
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> > File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc (right):
> > 
> >
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> > chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:14: #include
> > "ui/aura/desktop.h"
> > nit: sort
> 
> Done.

[Ian Vollick, 2011-11-22 16:51:15]

On 2011/11/22 16:35:31, sky wrote:
> Since the code uses aura it should live in chrome/browser/ui/views/aura

Done.

> 
>   -Scott
> 
> On 2011/11/22 15:45:44, vollick wrote:
> > The rebase was trickier than I'd hoped. The browser parts code has been
moved
> > around and the orientation listener has been moved from ui/touch/sensors to
> > ui/sensors since it has nothing to do with touch.
> > 
> > sky@, are you ok with the new home for the listener?
> > 
> > On 2011/11/21 21:43:06, sky wrote:
> > > LGTM
> > > 
> > >
> >
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> > > File chrome/browser/ui/touch/sensors/screen_orientation_listener.cc
(right):
> > > 
> > >
> >
>
http://codereview.chromium.org/8461017/diff/9001/chrome/browser/ui/touch/sens...
> > > chrome/browser/ui/touch/sensors/screen_orientation_listener.cc:14:
#include
> > > "ui/aura/desktop.h"
> > > nit: sort
> > 
> > Done.

[sky, 2011-11-22 17:41:29]

LGTM