Speculative Revert 108361 - in hope to fix Win Builder 2010

Speculative Revert 108361 - in hope to fix Win Builder 2010
http://build.chromium.org/p/chromium/builders/Win%20Builder%202010%20%28dbg%29/builds/12897


This CL is based on the patch:
   http://codereview.chromium.org/8416025

Use GYP to build nacl_irt

Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.

This broke the mac build due to a missing dependency where pthread.h was
unavailable.  This header gets copied to the correct location during the
prep_toolchain action.  I've added the appropriate dependency shown bellow
to the original patch.

This add the addition dependency to ppruntime
      'dependencies': [
        '<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
      ],

TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8440004

TBR=noelallen@google.com
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108446

[glotov, 2011-11-03 12:34:17]

Yes, this revert fixed the bot.

On Thu, Nov 3, 2011 at 3:06 PM,  <glotov@chromium.org> wrote:
> Reviewers: noelallen,
>
> Description:
> Speculative Revert 108361 - in hope to fix Win Builder 2010
>
http://build.chromium.org/p/chromium/builders/Win%20Builder%202010%20%28dbg%2...
>
>
> This CL is based on the patch:
>   http://codereview.chromium.org/8416025
>
> Use GYP to build nacl_irt
>
> Converts Chrome from using scons to using GYP when building nacl_irt.
> This change causes chrome to use GYP based components for untrusted
> code. As a benifit, GYP will no longer need to run and scrape scons
> output to determine irt dependencies. This also allows us to avoid
> invoking scons during the build process.
> We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
> issue on Windows.
>
> This broke the mac build due to a missing dependency where pthread.h was
> unavailable.  This header gets copied to the correct location during the
> prep_toolchain action.  I've added the appropriate dependency shown bellow
> to the original patch.
>
> This add the addition dependency to ppruntime
>      'dependencies': [
>        '<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
>      ],
>
> TEST= try
> BUG= http://code.google.com/p/chromium/issues/detail?id=96782
> Review URL: http://codereview.chromium.org/8440004
>
> TBR=noelallen@google.com
>
> Please review this at http://codereview.chromium.org/8423080/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  A  +  build/scan_sources.py
>  M     chrome/nacl.gypi
>  D     ppapi/native_client/native_client.gyp
>  M     ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp
>  M     ppapi/ppapi_tests.gypi
>
>
>



-- 
Thank you,
Denis