Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 8440004: This CL is based on the patch: (Closed)

Created:
9 years, 1 month ago by noelallen1
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

This CL is based on the patch: http://codereview.chromium.org/8416025 Use GYP to build nacl_irt Converts Chrome from using scons to using GYP when building nacl_irt. This change causes chrome to use GYP based components for untrusted code. As a benifit, GYP will no longer need to run and scrape scons output to determine irt dependencies. This also allows us to avoid invoking scons during the build process. We roll NaCl deps to get a fix for a simultaneous 32/64 bit build issue on Windows. This broke the mac build due to a missing dependency where pthread.h was unavailable. This header gets copied to the correct location during the prep_toolchain action. I've added the appropriate dependency shown bellow to the original patch. This add the addition dependency to ppruntime 'dependencies': [ '<(DEPTH)/native_client/src/tools.gyp:prep_toolchain' ], TEST= try BUG= http://code.google.com/p/chromium/issues/detail?id=96782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108361

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -311 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/scan_sources.py View 1 2 1 chunk +0 lines, -236 lines 0 comments Download
M chrome/nacl.gypi View 1 2 3 chunks +8 lines, -74 lines 0 comments Download
A ppapi/native_client/native_client.gyp View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
noelallen1
PTAL when you get a chance. It's the same patch as before but with the ...
9 years, 1 month ago (2011-11-01 18:57:26 UTC) #1
dmichael (off chromium)
9 years, 1 month ago (2011-11-01 19:04:09 UTC) #2
LGTM, just some nits.

http://codereview.chromium.org/8440004/diff/1001/chrome/nacl.gypi
File chrome/nacl.gypi (right):

http://codereview.chromium.org/8440004/diff/1001/chrome/nacl.gypi#newcode75
chrome/nacl.gypi:75: #issue
nit: space after #

http://codereview.chromium.org/8440004/diff/1001/ppapi/native_client/native_c...
File ppapi/native_client/native_client.gyp (right):

http://codereview.chromium.org/8440004/diff/1001/ppapi/native_client/native_c...
ppapi/native_client/native_client.gyp:44:
'-Wl,--section-start,.rodata=0x3ef00000',
nit: It would be nice to have some link or other reference for these magic
numbers.

Powered by Google App Engine
This is Rietveld 408576698