Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 8416025: Use GYP to build nacl_irt (Closed)

Created:
9 years, 1 month ago by noelallen1
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use GYP to build nacl_irt Converts Chrome from using scons to using GYP when building nacl_irt. This change causes chrome to use GYP based components for untrusted code. As a benifit, GYP will no longer need to run and scrape scons output to determine irt dependencies. This also allows us to avoid invoking scons during the build process. We roll NaCl deps to get a fix for a simultaneous 32/64 bit build issue on Windows. TEST= try BUG= http://code.google.com/p/chromium/issues/detail?id=96782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108116

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -76 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/scan_sources.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl.gypi View 1 3 chunks +11 lines, -74 lines 2 comments Download
A ppapi/native_client/native_client.gyp View 1 1 chunk +62 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy.gyp View 1 chunk +91 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
LGTM Can we also delete the build_nacl_irt.py script? http://codereview.chromium.org/8416025/diff/7/chrome/nacl.gypi File chrome/nacl.gypi (right): http://codereview.chromium.org/8416025/diff/7/chrome/nacl.gypi#newcode74 chrome/nacl.gypi:74: # ...
9 years, 1 month ago (2011-10-31 16:38:48 UTC) #1
noelallen_use_chromium
I'll clean it out after this CL has baked for a while. On Mon, Oct ...
9 years, 1 month ago (2011-10-31 17:51:22 UTC) #2
bradn
K, lgtm On Mon, Oct 31, 2011 at 10:51 AM, Noel Allen <noelallen@google.com> wrote: > ...
9 years, 1 month ago (2011-10-31 17:52:21 UTC) #3
sehr (please use chromium)
One nit. LGTM. http://codereview.chromium.org/8416025/diff/7/chrome/nacl.gypi File chrome/nacl.gypi (right): http://codereview.chromium.org/8416025/diff/7/chrome/nacl.gypi#newcode74 chrome/nacl.gypi:74: # shared with the 64-bit target, ...
9 years, 1 month ago (2011-10-31 19:47:40 UTC) #4
dmichael (off chromium)
lgtm rubber stamp
9 years, 1 month ago (2011-10-31 19:58:26 UTC) #5
joth
9 years, 1 month ago (2011-11-01 17:14:31 UTC) #6
I think this also broke the linux_redux build.

When you re-land, if you get chance could you also do:
  trychange.py -b linux_redux

Thanks!

Powered by Google App Engine
This is Rietveld 408576698