Classification of TODOs in Panel code.

chrome/browser/ui/panels/panel_manager.cc

Index: chrome/browser/ui/panels/panel_manager.cc
diff --git a/chrome/browser/ui/panels/panel_manager.cc b/chrome/browser/ui/panels/panel_manager.cc
index d2795eeb08e3b292d279505f780453399610c59d..15754885fad13925e6597fe5846a51fc1017c784 100644
--- a/chrome/browser/ui/panels/panel_manager.cc
+++ b/chrome/browser/ui/panels/panel_manager.cc
@@ -429,10 +429,10 @@ void PanelManager::BringUpOrDownTitlebars(bool bring_up) {
   // it makes it possible to hit the titlebar on OSX if Dock has Magnifying
   // enabled - the panels stay up for a while after Dock magnification effect
   // stops covering the panels.
-  // TODO(dimich): when there is implementation which has both delays to be
-  // different from zero, figure out what shoudl be the combined delay.
-  if (!bring_up &&
-      task_delay_milliseconds < kMillisecondsBeforeCollapsingFromTitleOnlyState)
+  // When there is an implementation that employs both delays, figure out how
+  // to combine them.

[prasadt, 2011/11/02 23:01:58]

That sounds like a TODO that doesn't say TODO. Should be a TODO, bug or the line
should just be removed.

[Dmitry Titov, 2011/11/02 23:32:19]

I've reworded it, wanted an explanation for an assumption that DCHECK is
verifying.

+  DCHECK(task_delay_milliseconds == 0);
+  if (!bring_up)

[Dmitry Titov, 2011/11/02 22:15:01]

Who was I kidding? Having code for non-existing and not-understood conditions 
is never a good thing.

     task_delay_milliseconds = kMillisecondsBeforeCollapsingFromTitleOnlyState;
 
   // OnAutoHidingDesktopBarVisibilityChanged will handle this.