Classification of TODOs in Panel code.

chrome/browser/ui/panels/panel_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 411 matching lines @@
       task_delay_milliseconds =
           kMaxMillisecondsWaitForBottomBarVisibilityChange;
     }
   }
 
   // On some OSes, the interaction with native Taskbars/Docks may be improved
   // if the panels do not go back to minimized state too fast. For example,
   // it makes it possible to hit the titlebar on OSX if Dock has Magnifying
   // enabled - the panels stay up for a while after Dock magnification effect
   // stops covering the panels.
-  // TODO(dimich): when there is implementation which has both delays to be
-  // different from zero, figure out what shoudl be the combined delay.
-  if (!bring_up &&
-      task_delay_milliseconds < kMillisecondsBeforeCollapsingFromTitleOnlyState)
+  // When there is an implementation that employs both delays, figure out how
+  // to combine them.

[prasadt, 2011/11/02 23:01:58]

That sounds like a TODO that doesn't say TODO. Should be a TODO, bug or the line
should just be removed.

[Dmitry Titov, 2011/11/02 23:32:19]

I've reworded it, wanted an explanation for an assumption that DCHECK is
verifying.

+  DCHECK(task_delay_milliseconds == 0);
+  if (!bring_up)

[Dmitry Titov, 2011/11/02 22:15:01]

Who was I kidding? Having code for non-existing and not-understood conditions 
is never a good thing.

     task_delay_milliseconds = kMillisecondsBeforeCollapsingFromTitleOnlyState;
 
   // OnAutoHidingDesktopBarVisibilityChanged will handle this.
   delayed_titlebar_action_ = bring_up ? BRING_UP : BRING_DOWN;
   if (remove_delays_for_testing_)
     task_delay_milliseconds = 0;
 
   // If user moves the mouse in and out of mouse tracking area, we might have
   // previously posted but not yet dispatched task in the queue. New action
   // shoudl always 'reset' the delays so cancel the old task and post a new one.
@@ skipping 151 matching lines @@
   // Start from the bottom to avoid reshuffling.
   for (Panels::reverse_iterator iter = panels_copy.rbegin();
        iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool PanelManager::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }