Classification of TODOs in Panel code.

chrome/browser/ui/panels/panel_browser_view.cc

Index: chrome/browser/ui/panels/panel_browser_view.cc
diff --git a/chrome/browser/ui/panels/panel_browser_view.cc b/chrome/browser/ui/panels/panel_browser_view.cc
index de26f11cd2a80ebf9fd86658f0f8e7714df63f37..ba40254f6305df8da45ea5c4f565a6404a346500 100644
--- a/chrome/browser/ui/panels/panel_browser_view.cc
+++ b/chrome/browser/ui/panels/panel_browser_view.cc
@@ -93,7 +93,8 @@ void PanelBrowserView::Deactivate() {
   else
     ::SetFocus(NULL);
 #else
-  // TODO(jianli): to be implemented for other platform.
+  // TODO(jianli): Implement for USE_AURA.

[Dmitry Titov, 2011/11/02 22:15:01]

Didn't want a bug for this, maybe we shoudl just remove this because
NOTIMPLEMENTED() is enough?

[jennb, 2011/11/02 22:25:31]

Agree w/ removing TODO.

[Dmitry Titov, 2011/11/02 23:32:19]

Done.

+  NOTIMPLEMENTED();
   BrowserView::Deactivate();
 #endif
 }
@@ -147,7 +148,7 @@ void PanelBrowserView::OnWidgetActivationChanged(views::Widget* widget,
   ::BrowserView::OnWidgetActivationChanged(widget, active);
 
 #if defined(USE_AURA)
-  // TODO(beng):
+  // TODO(beng): Implement for USE_AURA.
   NOTIMPLEMENTED();
   bool focused = active;
 #elif defined(OS_WIN)
@@ -156,7 +157,7 @@ void PanelBrowserView::OnWidgetActivationChanged(views::Widget* widget,
   bool focused = active &&
       GetFrameView()->GetWidget()->GetNativeView() == ::GetForegroundWindow();
 #else
-  // TODO(jianli): Investigate focus behavior for ChromeOS
+  NOTREACHED();  // View-based Panels are not enabled anywhere else.

[jennb, 2011/11/02 22:25:31]

Can we delete the #else clause completely and convert the #elif into #else?

[Dmitry Titov, 2011/11/02 23:32:19]

Done.
Made it consistent with the case in Deactivate(): 


#if defined(OS_WIN) && !defined(USE_AURA)
...
#else
  NOTIMPLEMENTED();
#endif

   bool focused = active;
 #endif
 
@@ -511,7 +512,7 @@ void NativePanelTestingWin::ReleaseMouseButtonTitlebar() {
 void NativePanelTestingWin::DragTitlebar(int delta_x, int delta_y) {
   // TODO(jianli): Need a comment here that explains why we use
   // mouse_pressed_point_ and not current bounds as obtained by
-  // GetRestoredBounds().
+  // GetRestoredBounds(). http://crbug.com/102730
   panel_browser_view_->OnTitlebarMouseDragged(gfx::Point(
       panel_browser_view_->mouse_pressed_point_.x() + delta_x,
       panel_browser_view_->mouse_pressed_point_.y() + delta_y));