chrome/browser/safe_browsing/protocol_manager.cc - Issue 8417040: Measure how often downloaded executables match the download whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 8417040: Measure how often downloaded executables match the download whitelist. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/download_protection_service.cc ('K') | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | chrome/browser/safe_browsing/protocol_parser.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_manager.cc

diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc

index ac4ca9d2ed98d2208ffbf83a9d77b65193902425..5de97f37012d791170477ddee0c03da639f6dc01 100644

--- a/chrome/browser/safe_browsing/protocol_manager.cc

+++ b/chrome/browser/safe_browsing/protocol_manager.cc

@@ -432,7 +432,7 @@ bool SafeBrowsingProtocolManager::HandleServiceResponse(const GURL& url,

std::string data_str;

data_str.assign(data, length);

std::string encoded_chunk;

- base::Base64Encode(data, &encoded_chunk);

+ base::Base64Encode(data_str, &encoded_chunk);

Brian Ryner 2011/10/28 23:00:59 Nice catch.

VLOG(1) << "ParseChunk error for chunk: " << chunk_url.url

<< ", client_key: " << client_key_

<< ", wrapped_key: " << wrapped_key_