chrome/browser/safe_browsing/protocol_parser.cc - Issue 8417040: Measure how often downloaded executables match the download whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 8417040: Measure how often downloaded executables match the download whitelist. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/protocol_manager.cc ('K') | « chrome/browser/safe_browsing/protocol_manager.cc ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_parser.cc

diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc

index c6edf116dffa596233a38555a666322e18d03210..f8ab1aa75e9dc10c77f9112c0146c23e2e9e4e20 100644

--- a/chrome/browser/safe_browsing/protocol_parser.cc

+++ b/chrome/browser/safe_browsing/protocol_parser.cc

@@ -335,8 +335,9 @@ bool SafeBrowsingProtocolParser::ParseAddChunk(const std::string& list_name,

SBEntry::Type type = hash_len == sizeof(SBPrefix) ?

SBEntry::ADD_PREFIX : SBEntry::ADD_FULL_HASH;

- if (list_name == safe_browsing_util::kBinHashList) {

- // kBinHashList only contains prefixes, no HOSTKEY and COUNT.

+ if (list_name == safe_browsing_util::kBinHashList ||

+ list_name == safe_browsing_util::kDownloadWhiteList) {

+ // These lists only contain prefixes, no HOSTKEY and COUNT.

DCHECK_EQ(0, remaining % hash_len);

prefix_count = remaining / hash_len;

SBChunkHost chunk_host;