Measure how often downloaded executables match the download whitelist.

chrome/browser/safe_browsing/safe_browsing_service.cc

Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 3f99699dd9db9b247be5d74b60d75dd478c8d68f..c8a4ea474736ee5885cda99917f0d846c97a6b35 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -913,8 +913,11 @@ void SafeBrowsingService::Start() {
       !cmdline->HasSwitch(switches::kDisableClientSidePhishingDetection);
 #endif
 
-  enable_download_whitelist_ = cmdline->HasSwitch(
-      switches::kEnableImprovedDownloadProtection);
+  // TODO(noelutz): remove this boolean variable since it should always be true
+  // if SafeBrowsing is enabled.  Unfortunately, we have no test data for this
+  // list right now.  This means that we need to be able to disable this list
+  // for the SafeBrowsing test to pass.
+  enable_download_whitelist_ = enable_csd_whitelist_;

[Brian Ryner, 2011/10/28 23:00:59]

This will cause the --disable-client-side-phishing-detection flag to also turn
off the download whitelist, is that intentional?

[noelutz, 2011/10/28 23:11:24]

Yes.  That's intentional.  We need a way to disable it for the SB test.  Instead
of creating a new flag I re-use the one from csd :-(.  It's only used for the
test so I thought that was OK.  At some point I need to bug Garrett to generate
new test data with the new lists or show me how to do it.

 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,