Measure how often downloaded executables match the download whitelist.

Measure how often downloaded executables match the download whitelist.
This CL also tells all Chrome users who have SafeBrowsing turned on to
download this new whitelist.

BUG=
TEST=SafeBrowsingProtocolParsingTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107885

[Brian Ryner, 2011-10-28 23:00:58]

Just a couple of minor things.

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service.cc:202:
UMA_HISTOGRAM_BOOLEAN("SBClientDownload.SignedOrWhitelistedDownload",
Should this be UMA_HISTOGRAM_COUNTS given how you're using it here?

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/pr...
File chrome/browser/safe_browsing/protocol_manager.cc (right):

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/pr...
chrome/browser/safe_browsing/protocol_manager.cc:435:
base::Base64Encode(data_str, &encoded_chunk);
Nice catch.

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_service.cc:920:
enable_download_whitelist_ = enable_csd_whitelist_;
This will cause the --disable-client-side-phishing-detection flag to also turn
off the download whitelist, is that intentional?

[noelutz, 2011-10-28 23:11:24]

Thanks.  Please take another look.

noe.

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/do...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/do...
chrome/browser/safe_browsing/download_protection_service.cc:202:
UMA_HISTOGRAM_BOOLEAN("SBClientDownload.SignedOrWhitelistedDownload",
On 2011/10/28 23:00:59, Brian Ryner wrote:
> Should this be UMA_HISTOGRAM_COUNTS given how you're using it here?

Done.

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_service.cc (right):

http://codereview.chromium.org/8417040/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_service.cc:920:
enable_download_whitelist_ = enable_csd_whitelist_;
On 2011/10/28 23:00:59, Brian Ryner wrote:
> This will cause the --disable-client-side-phishing-detection flag to also turn
> off the download whitelist, is that intentional?

Yes.  That's intentional.  We need a way to disable it for the SB test.  Instead
of creating a new flag I re-use the one from csd :-(.  It's only used for the
test so I thought that was OK.  At some point I need to bug Garrett to generate
new test data with the new lists or show me how to do it.

[Brian Ryner, 2011-10-28 23:16:52]

lgtm

[noelutz, 2011-10-28 23:45:48]

On 2011/10/28 23:16:52, Brian Ryner wrote:
> lgtm

Matt, if you think this CL looks good to you do you mind letting it through the
commit-queue?  Ideally, I would like this CL to be submitted before Sunday to
make next week's dev channel.

[mattm, 2011-10-29 03:29:23]

lgtm

[commit-bot: I haz the power, 2011-10-29 03:29:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8417040/5001

[commit-bot: I haz the power, 2011-10-29 05:45:33]

Try job failure for 8417040-5001 (retry) on mac_rel for step "ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-10-29 21:25:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noelutz@google.com/8417040/5001

[commit-bot: I haz the power, 2011-10-29 22:32:03]

Change committed as 107885