Measure how often downloaded executables match the download whitelist.

chrome/browser/safe_browsing/safe_browsing_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/path_service.h"
@@ skipping 895 matching lines @@
   // enabled.
 #ifdef OS_CHROMEOS
   // Client-side detection is disabled on ChromeOS for now, so don't bother
   // downloading the whitelist.
   enable_csd_whitelist_ = false;
 #else
   enable_csd_whitelist_ =
       !cmdline->HasSwitch(switches::kDisableClientSidePhishingDetection);
 #endif
 
-  enable_download_whitelist_ = cmdline->HasSwitch(
-      switches::kEnableImprovedDownloadProtection);
+  // TODO(noelutz): remove this boolean variable since it should always be true
+  // if SafeBrowsing is enabled.  Unfortunately, we have no test data for this
+  // list right now.  This means that we need to be able to disable this list
+  // for the SafeBrowsing test to pass.
+  enable_download_whitelist_ = enable_csd_whitelist_;

[Brian Ryner, 2011/10/28 23:00:59]

This will cause the --disable-client-side-phishing-detection flag to also turn
off the download whitelist, is that intentional?

[noelutz, 2011/10/28 23:11:24]

Yes.  That's intentional.  We need a way to disable it for the SB test.  Instead
of creating a new flag I re-use the one from csd :-(.  It's only used for the
test so I thought that was OK.  At some point I need to bug Garrett to generate
new test data with the new lists or show me how to do it.

 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableMethod(
           this, &SafeBrowsingService::OnIOInitialize, client_key, wrapped_key,
           request_context_getter));
 }
 
 void SafeBrowsingService::Stop() {
   BrowserThread::PostTask(
@@ skipping 428 matching lines @@
     Stop();
 
   if (csd_service_.get())
     csd_service_->SetEnabledAndRefreshState(enable);
   if (download_service_.get()) {
     download_service_->SetEnabled(
         enable && CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kEnableImprovedDownloadProtection));
   }
 }