Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 8417040: Measure how often downloaded executables match the download whitelist. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Address Brian's comment. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/protocol_parser_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 3f99699dd9db9b247be5d74b60d75dd478c8d68f..c8a4ea474736ee5885cda99917f0d846c97a6b35 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -913,8 +913,11 @@ void SafeBrowsingService::Start() {
!cmdline->HasSwitch(switches::kDisableClientSidePhishingDetection);
#endif
- enable_download_whitelist_ = cmdline->HasSwitch(
- switches::kEnableImprovedDownloadProtection);
+ // TODO(noelutz): remove this boolean variable since it should always be true
+ // if SafeBrowsing is enabled. Unfortunately, we have no test data for this
+ // list right now. This means that we need to be able to disable this list
+ // for the SafeBrowsing test to pass.
+ enable_download_whitelist_ = enable_csd_whitelist_;
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
« no previous file with comments | « chrome/browser/safe_browsing/protocol_parser_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698