net/socket/ssl_server_socket_nss.cc - Issue 8414047: Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_server_socket_nss.cc

Issue 8414047: Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Errant comment Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_server_socket_nss.cc

diff --git a/net/socket/ssl_server_socket_nss.cc b/net/socket/ssl_server_socket_nss.cc

index 43160495f08f323409b0fc6986f40ac0f9e096a9..8f1b43b97714157ab2cc63350f6927d217f757b3 100644

--- a/net/socket/ssl_server_socket_nss.cc

+++ b/net/socket/ssl_server_socket_nss.cc

@@ -357,7 +357,7 @@ int SSLServerSocketNSS::InitializeSSLOptions() {

// Get a certificate of CERTCertificate structure.

std::string der_string;

- if (!cert_->GetDEREncoded(&der_string))

+ if (!X509Certificate::GetDEREncoded(cert_->os_cert_handle(), &der_string))

return ERR_UNEXPECTED;

SECItem der_cert;

« net/base/x509_certificate.h ('K') | « net/http/http_stream_factory_impl_job.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »