Make X509Certificate::GetDEREncoded a static function taking an OSCertHandle

net/base/x509_certificate.h

Index: net/base/x509_certificate.h
diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h
index aee2447c761162675b1eeb5909187ab6a421327b..35aa871fd8c9e485ff797da33ce4c35eb1a999a9 100644
--- a/net/base/x509_certificate.h
+++ b/net/base/x509_certificate.h
@@ -340,10 +340,11 @@ class NET_EXPORT X509Certificate
   // Returns true if it matches.
   bool VerifyNameMatch(const std::string& hostname) const;
 
-  // This method returns the DER encoded certificate.
-  // If the return value is true then the DER encoded certificate is available.
-  // The content of the DER encoded certificate is written to |encoded|.
-  bool GetDEREncoded(std::string* encoded);
+  // This method returns the DER encoded data from an OSCertHandle.

[wtc, 2011/10/31 19:05:41]

The |certificate| used in the original comment is
more precise than |data|.

+  // If the return value is true, then the DER encoded certificate is written
+  // to |der_encoded|.

[wtc, 2011/10/31 19:05:41]

We should say something like "On success, returns true and writes the DER
encoded certificate to |*der_encoded|." to emphasize the
meaning of the return value.  It's obvious though.

+  static bool GetDEREncoded(OSCertHandle cert_handle,
+                            std::string* der_encoded);
 
   OSCertHandle os_cert_handle() const { return cert_handle_; }