Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 8413028: Widen suppressoin for 101853 (Closed)

Created:
9 years, 1 month ago by oshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Widen suppressoin for 101853 Add more race/overlaps for 93932. Renamed 93932 issues in mac to have _mac_ as same suppression exists on suppression.txt TBR=acolwell@chromium.org,rvargas@chromium.org BUG=101853, 93932 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107693

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -29 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 4 chunks +32 lines, -27 lines 5 comments Download
M tools/valgrind/tsan/suppressions_mac.txt View 3 chunks +27 lines, -2 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
oshima
9 years, 1 month ago (2011-10-28 07:34:01 UTC) #1
Timur Iskhodzhanov
http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppressions.txt File tools/valgrind/tsan/suppressions.txt (right): http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppressions.txt#newcode635 tools/valgrind/tsan/suppressions.txt:635: <Put your suppression name here> baaah http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppressions.txt#newcode641 tools/valgrind/tsan/suppressions.txt:641: fun:media::FFmpegVideoDecodeEngine::DecodeFrame ...
9 years, 1 month ago (2011-10-28 08:26:20 UTC) #2
oshima
9 years, 1 month ago (2011-10-28 17:17:26 UTC) #3
Oops, sorry for mess. I found them late night and did it just before I go to
bed. Andrew actually told me about name problem, and he said he will submit fix
soon, so I didn't look it again.

http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppression...
File tools/valgrind/tsan/suppressions.txt (right):

http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppression...
tools/valgrind/tsan/suppressions.txt:635: <Put your suppression name here>
These seems to be cut&pasted without my intention. Sorry about that.

http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppression...
File tools/valgrind/tsan/suppressions_mac.txt (right):

http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppression...
tools/valgrind/tsan/suppressions_mac.txt:176: bug_93932_mac_b
On 2011/10/28 08:26:20, Timur Iskhodzhanov wrote:
> any reason to have Mac-only suppression duplicating the cross-platform one?

The particular error was happening on mac only because the stack was slightly
different from 93932 in suppression.txt. I added to mac first, then realized
that there is similar one in suppression.txt. I updated 93932 but apparently
I forgot to remove this one.

> are you aware tsan/suppressions.txt is used on all platforms
> + Mac is using tsan/suppressions_mac.txt ?

yes

http://codereview.chromium.org/8413028/diff/1/tools/valgrind/tsan/suppression...
tools/valgrind/tsan/suppressions_mac.txt:213: Memcheck:Overlap
On 2011/10/28 08:26:20, Timur Iskhodzhanov wrote:
> Memcheck doesn't check this file - please remove

Sorry about that. I'll be careful next time.
One note: waterfall.sh didn't complain about this, and did hide this error. It'd
be nice if waterfall.sh can catch this type of error.

Powered by Google App Engine
This is Rietveld 408576698