Widen suppressoin for 101853

tools/valgrind/tsan/suppressions_mac.txt

 # There are two kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. Intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 146 matching lines @@
   fun:*PCMQueueOutAudioOutputStream*Stop*
 }
 
 #-----------------------------------------------------------------------
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
 
 {
-   bug_93932_a
+   bug_93932_mac_a
    ThreadSanitizer:Race
    fun:frame_thread_free
    fun:avcodec_close
    fun:media::FFmpegVideoDecodeEngine::~FFmpegVideoDecodeEngine
    fun:scoped_ptr::reset
    fun:media::FFmpegVideoDecodeEngineTest::~FFmpegVideoDecodeEngineTest
 }
 {
-   bug_97822
+   bug_93932_mac_b

[Timur Iskhodzhanov, 2011/10/28 08:26:20]

any reason to have Mac-only suppression duplicating the cross-platform one?

are you aware tsan/suppressions.txt is used on all platforms
+ Mac is using tsan/suppressions_mac.txt ?

[oshima, 2011/10/28 17:17:26]

The particular error was happening on mac only because the stack was slightly
different from 93932 in suppression.txt. I added to mac first, then realized
that there is similar one in suppression.txt. I updated 93932 but apparently
I forgot to remove this one.
yes

+   ThreadSanitizer:Race
+   fun:frame_thread_free
+   ...
+   fun:avcodec_close
+   fun:media::FFmpegVideoDecodeEngine::~FFmpegVideoDecodeEngine
+   ...
+   fun:scoped_ptr::~scoped_ptr
+   fun:media::FFmpegVideoDecoder::~FFmpegVideoDecoder
+   ...
+   fun:scoped_refptr::~scoped_refptr
+   fun:media::FFmpegVideoDecoderTest::~FFmpegVideoDecoderTest
+}
+{
+   bug_93932_mac_c
    ThreadSanitizer:Race
    ...
    fun:media::FFmpegVideoDecodeEngine::DecodeFrame
    fun:media::FFmpegVideoDecodeEngine::ConsumeVideoSample
    fun:media::DemuxCompleteActionP2::gmock_Impl::gmock_PerformImpl
    fun:testing::internal::ActionHelper::Perform
    fun:testing::Action::Perform
    fun:testing::internal::ActionResultHolder::PerformAction
    fun:testing::internal::FunctionMockerBase::UntypedPerformAction
    fun:testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith
    fun:testing::internal::FunctionMockerBase::InvokeWith
    fun:testing::internal::FunctionMocker::Invoke
    fun:media::FFmpegVideoDecodeEngineTest::ProduceVideoSample
    fun:media::FFmpegVideoDecodeEngineTest::ProduceVideoSample
    fun:media::FFmpegVideoDecodeEngine::ReadInput
    fun:media::FFmpegVideoDecodeEngine::ProduceVideoFrame
    fun:media::FFmpegVideoDecodeEngineTest::CallProduceVideoFrame
    fun:media::FFmpegVideoDecodeEngineTest::DecodeIFrameThenTestFile
    fun:media::FFmpegVideoDecodeEngineTest_DecodeFrame_SmallerWidth_Test::TestBody
 }
 {
+   bug_93932_mac_d
+   Memcheck:Overlap

[Timur Iskhodzhanov, 2011/10/28 08:26:20]

Memcheck doesn't check this file - please remove

[oshima, 2011/10/28 17:17:26]

Sorry about that. I'll be careful next time.
One note: waterfall.sh didn't complain about this, and did hide this error. It'd
be nice if waterfall.sh can catch this type of error.

+   fun:memcpy
+   fun:vp8_decode_update_thread_context
+   ...
+   fun:avcodec_decode_video2
+   fun:_ZN5media23FFmpegVideoDecodeEngine11DecodeFrameE13scoped_refptrINS_6BufferEE
+   fun:_ZN5media23FFmpegVideoDecodeEngine18ConsumeVideoSampleE13scoped_refptrINS_6BufferEE
+   fun:_ZN5media18FFmpegVideoDecoder18OnReadCompleteTaskE13scoped_refptrINS_6BufferEE
+}
+{
   bug_100313 TSan false positive
   ThreadSanitizer:Race
   ...
   fun:__sfp
   fun:fopen
   fun:file_util::OpenFile
   fun:base::SharedMemory::CreateNamed
 }
 {
   bug_100772a
@@ skipping 28 matching lines @@
   fun:MIO::DAL::System::AtExitHandler
   fun:MIO::DAL::AtExit::AtExitHandler
 }
 {
   bug_100772d
   ThreadSanitizer:Race
   fun:DVSignalSync
   fun:DVDeviceTerminate
 }