Widen suppressoin for 101853

tools/valgrind/tsan/suppressions_mac.txt

Index: tools/valgrind/tsan/suppressions_mac.txt
diff --git a/tools/valgrind/tsan/suppressions_mac.txt b/tools/valgrind/tsan/suppressions_mac.txt
index 9634899dbb2684279947ab707888b594663462db..221bf89665fdd15543cb4c8ab11862ed62c2f53b 100644
--- a/tools/valgrind/tsan/suppressions_mac.txt
+++ b/tools/valgrind/tsan/suppressions_mac.txt
@@ -164,7 +164,7 @@
 # running overnight and removing outdated bugs/suppressions.
 
 {
-   bug_93932_a
+   bug_93932_mac_a
    ThreadSanitizer:Race
    fun:frame_thread_free
    fun:avcodec_close
@@ -173,7 +173,21 @@
    fun:media::FFmpegVideoDecodeEngineTest::~FFmpegVideoDecodeEngineTest
 }
 {
-   bug_97822
+   bug_93932_mac_b

[Timur Iskhodzhanov, 2011/10/28 08:26:20]

any reason to have Mac-only suppression duplicating the cross-platform one?

are you aware tsan/suppressions.txt is used on all platforms
+ Mac is using tsan/suppressions_mac.txt ?

[oshima, 2011/10/28 17:17:26]

The particular error was happening on mac only because the stack was slightly
different from 93932 in suppression.txt. I added to mac first, then realized
that there is similar one in suppression.txt. I updated 93932 but apparently
I forgot to remove this one.
yes

+   ThreadSanitizer:Race
+   fun:frame_thread_free
+   ...
+   fun:avcodec_close
+   fun:media::FFmpegVideoDecodeEngine::~FFmpegVideoDecodeEngine
+   ...
+   fun:scoped_ptr::~scoped_ptr
+   fun:media::FFmpegVideoDecoder::~FFmpegVideoDecoder
+   ...
+   fun:scoped_refptr::~scoped_refptr
+   fun:media::FFmpegVideoDecoderTest::~FFmpegVideoDecoderTest
+}
+{
+   bug_93932_mac_c
    ThreadSanitizer:Race
    ...
    fun:media::FFmpegVideoDecodeEngine::DecodeFrame
@@ -195,6 +209,17 @@
    fun:media::FFmpegVideoDecodeEngineTest_DecodeFrame_SmallerWidth_Test::TestBody
 }
 {
+   bug_93932_mac_d
+   Memcheck:Overlap

[Timur Iskhodzhanov, 2011/10/28 08:26:20]

Memcheck doesn't check this file - please remove

[oshima, 2011/10/28 17:17:26]

Sorry about that. I'll be careful next time.
One note: waterfall.sh didn't complain about this, and did hide this error. It'd
be nice if waterfall.sh can catch this type of error.

+   fun:memcpy
+   fun:vp8_decode_update_thread_context
+   ...
+   fun:avcodec_decode_video2
+   fun:_ZN5media23FFmpegVideoDecodeEngine11DecodeFrameE13scoped_refptrINS_6BufferEE
+   fun:_ZN5media23FFmpegVideoDecodeEngine18ConsumeVideoSampleE13scoped_refptrINS_6BufferEE
+   fun:_ZN5media18FFmpegVideoDecoder18OnReadCompleteTaskE13scoped_refptrINS_6BufferEE
+}
+{
   bug_100313 TSan false positive
   ThreadSanitizer:Race
   ...