Disable SPDY IP pooling for SSL connections with client authentication.

Disable SPDY IP pooling for SSL connections with client authentication.

Add a "bool client_cert_sent" member to SSLInfo to extract this info
from SSLClientSocket.

R=rtenneti@chromium.org
BUG=101778
TEST=new unit test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107671

[wtc, 2011-10-27 01:13:58]

Please review.  I will walk through this CL with you and
add more comments tomorrow.

http://codereview.chromium.org/8401024/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/8401024/diff/1/net/spdy/spdy_session.cc#newcod...
net/spdy/spdy_session.cc:345: bool SpdySession::VerifyDomainAuthentication(const
std::string& domain) {

We may want to rename this method because it does more than
verifying domain name now.

[ramant (doing other things), 2011-10-27 16:20:33]

lgtm.

http://codereview.chromium.org/8401024/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/8401024/diff/1/net/spdy/spdy_session.cc#newcod...
net/spdy/spdy_session.cc:345: bool SpdySession::VerifyDomainAuthentication(const
std::string& domain) {
On 2011/10/27 01:13:58, wtc wrote:
> 
> We may want to rename this method because it does more than
> verifying domain name now.

+1

[wtc, 2011-10-27 19:18:12]

rtenneti: please review Patch Set 2.

rsleevi: just FYI -- I added a new "bool client_cert_sent"
member to SSLInfo because this info is useful to SPDY SSL
connection sharing.

[ramant (doing other things), 2011-10-27 21:06:11]

lgtm

[commit-bot: I haz the power, 2011-10-27 23:49:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/8401024/13002

[commit-bot: I haz the power, 2011-10-28 01:18:12]

Change committed as 107671