net/spdy/spdy_session.h - Issue 8401024: Disable SPDY IP pooling for SSL connections with client authentication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.h

Issue 8401024: Disable SPDY IP pooling for SSL connections with client authentication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Remove an incorrect test case Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_session.h

===================================================================

--- net/spdy/spdy_session.h (revision 107497)

+++ net/spdy/spdy_session.h (working copy)

@@ -99,9 +99,13 @@

// Check to see if this SPDY session can support an additional domain.

// If the session is un-authenticated, then this call always returns true.

- // For SSL-based sessions, verifies that the certificate in use by this

- // session provides authentication for the domain.

+ // For SSL-based sessions, verifies that the server certificate in use by

+ // this session provides authentication for the domain and no client

+ // certificate was sent to the original server during the SSL handshake.

// NOTE: This function can have false negatives on some platforms.

+ // TODO(wtc): rename this function and the Net.SpdyIPPoolDomainMatch

+ // histogram because this function does more than verifying domain

+ // authentication now.

bool VerifyDomainAuthentication(const std::string& domain);

// Send the SYN frame for |stream_id|. This also sends PING message to check

« no previous file with comments | « net/socket/ssl_client_socket_win.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »