Issue 8371006: Reapply r106708 "Include initial use of colorama"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8371006: Reapply r106708 "Include initial use of colorama" (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Reapply r106708 "Include initial use of colorama" isatty() wasn't defined on Windows, causing it to crash. R=dpranke@chromium.org BUG= TEST=manually gclient sync on windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106865

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+848 lines, -4 lines)			Patch
M	gclient.py	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	pylintrc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/colorama/LICENSE.txt	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	third_party/colorama/README.chromium	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	third_party/colorama/README.txt	View	1 chunk	+264 lines, -0 lines	0 comments	Download
A	third_party/colorama/__init__.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	third_party/colorama/ansi.py	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	third_party/colorama/ansitowin32.py	View	1 chunk	+189 lines, -0 lines	0 comments	Download
A	third_party/colorama/initialise.py	View	1 chunk	+55 lines, -0 lines	0 comments	Download
A	third_party/colorama/win32.py	View	1 chunk	+109 lines, -0 lines	0 comments	Download
A	third_party/colorama/winterm.py	View	1 chunk	+120 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

M-A Ruel

Dependent on http://codereview.chromium.org/8370004. Original review at http://codereview.chromium.org/8365001.

9 years, 2 months ago (2011-10-21 19:32:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8371006/1

9 years, 2 months ago (2011-10-23 00:08:10 UTC) #3

Change committed as 106865