Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 8365001: Include initial use of colorama (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Include initial use of colorama For now only affect gclient help to figure out if there is any issue with it. Because of the way it's done, there is no way to disable coloring, which could be annoying when redirected. This needs to be taken in consideration. R=dpranke@chromium.org TEST=manually tested on linux, cygwin and windows, both run manually and redirected to a text file. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -4 lines) Patch
M gclient.py View 3 chunks +12 lines, -3 lines 0 comments Download
M pylintrc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/colorama/LICENSE.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/colorama/README.chromium View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/colorama/README.txt View 1 chunk +264 lines, -0 lines 0 comments Download
A third_party/colorama/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/colorama/ansi.py View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/colorama/ansitowin32.py View 1 chunk +189 lines, -0 lines 0 comments Download
A third_party/colorama/initialise.py View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/colorama/win32.py View 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/colorama/winterm.py View 1 chunk +120 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-20 16:16:40 UTC) #1
Dirk Pranke
Personally, I wouldn't bother with this change, but maybe I'm too old-school to appreciate things ...
9 years, 2 months ago (2011-10-21 02:53:50 UTC) #2
M-A Ruel
On 2011/10/21 02:53:50, Dirk Pranke wrote: > Personally, I wouldn't bother with this change, but ...
9 years, 2 months ago (2011-10-21 12:43:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8365001/1
9 years, 2 months ago (2011-10-21 12:49:05 UTC) #4
commit-bot: I haz the power
Change committed as 106708
9 years, 2 months ago (2011-10-21 12:55:16 UTC) #5
M-A Ruel
9 years, 2 months ago (2011-10-21 13:33:03 UTC) #6
On 2011/10/21 12:55:16, I haz the power (commit-bot) wrote:
> Change committed as 106708

Sadly, this broke sync on Windows. Will redo.

Powered by Google App Engine
This is Rietveld 408576698