Improve the sys.stdout proxy to be more transparent.

Improve the sys.stdout proxy to be more transparent.

Otherwise isatty() could not be proxied correctly.

R=dpranke@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106864

[Dirk Pranke, 2011-10-21 21:14:48]

lgtm.

http://codereview.chromium.org/8370004/diff/1/gclient_utils.py
File gclient_utils.py (right):

http://codereview.chromium.org/8370004/diff/1/gclient_utils.py#newcode252
gclient_utils.py:252: finally:
Nit: what exceptions could be raised in here that require the try/finally?

[M-A Ruel, 2011-10-22 01:35:59]

http://codereview.chromium.org/8370004/diff/1/gclient_utils.py
File gclient_utils.py (right):

http://codereview.chromium.org/8370004/diff/1/gclient_utils.py#newcode252
gclient_utils.py:252: finally:
On 2011/10/21 21:14:48, Dirk Pranke wrote:
> Nit: what exceptions could be raised in here that require the try/finally?

Someone set sys.stdout.delay = None by error. If the try/finally is not there,
the lock will not be released, causing a deadlock on next print().

[commit-bot: I haz the power, 2011-10-22 23:58:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8370004/1

[commit-bot: I haz the power, 2011-10-23 00:04:36]

Change committed as 106864