Issue 8361026: Add checked mode option to CompileService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8361026: Add checked mode option to CompileService. (Closed)

Created:
9 years, 2 months ago by Kelly Norton

Modified:
9 years, 2 months ago

Reviewers:
pdr, fmalita_google_do_not_use

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Add checked mode option to CompileService. BUG= TEST=

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -8 lines)			Patch
	M	client/fling/src/java/core/com/google/dart/CompileService.java	View		4 chunks	+30 lines, -8 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pdr

LGTM for adding the check parameter. Why not set it to true? http://codereview.chromium.org/8361026/diff/1/client/fling/src/java/core/com/google/dart/CompileService.java File client/fling/src/java/core/com/google/dart/CompileService.java ...

9 years, 2 months ago (2011-10-21 14:35:31 UTC) #2

Kelly Norton

9 years, 2 months ago (2011-10-21 15:55:26 UTC) #3

http://codereview.chromium.org/8361026/diff/1/client/fling/src/java/core/com/...
File client/fling/src/java/core/com/google/dart/CompileService.java (right):

http://codereview.chromium.org/8361026/diff/1/client/fling/src/java/core/com/...
client/fling/src/java/core/com/google/dart/CompileService.java:169: return
create(false);
Preserving the current behavior for now.

Expand Messages | Collapse Messages