Chromium Code Reviews| Index: client/fling/src/java/core/com/google/dart/CompileService.java |
| diff --git a/client/fling/src/java/core/com/google/dart/CompileService.java b/client/fling/src/java/core/com/google/dart/CompileService.java |
| index 6aff85b0e4eecebaa078ea2767642314244c5714..fb888910b0047df70e6c18abc77bbab49ad26fa6 100644 |
| --- a/client/fling/src/java/core/com/google/dart/CompileService.java |
| +++ b/client/fling/src/java/core/com/google/dart/CompileService.java |
| @@ -166,14 +166,22 @@ public class CompileService { |
| private final static String FAKE_NAME = "tator"; |
| public static CompileService create() { |
| - final CompilerConfiguration config = config(true); |
| + return create(false); |
|
pdr
2011/10/21 14:35:31
Why not true?
Kelly Norton
2011/10/21 15:55:27
Preserving the current behavior for now.
|
| + } |
| + |
| + public static CompileService create(LibrarySource lib) { |
| + return create(lib, false); |
| + } |
| + |
| + public static CompileService create(boolean useCheckedMode) { |
| + final CompilerConfiguration config = config(true, useCheckedMode); |
| final LibrarySource lib = config.getSystemLibraryFor("dart:core"); |
| - return new CompileService(buildArtifactsFor(config, lib), lib); |
| + return new CompileService(buildArtifactsFor(config, lib), lib, useCheckedMode); |
| } |
| - public static CompileService create(LibrarySource lib) { |
| - final CompilerConfiguration config = config(true); |
| - return new CompileService(buildArtifactsFor(config, lib), lib); |
| + public static CompileService create(LibrarySource lib, boolean useCheckedMode) { |
| + final CompilerConfiguration config = config(true, useCheckedMode); |
| + return new CompileService(buildArtifactsFor(config, lib), lib, useCheckedMode); |
| } |
| private static ThreadSafeArtifacts buildArtifactsFor(CompilerConfiguration config, LibrarySource lib) { |
| @@ -209,12 +217,22 @@ public class CompileService { |
| } |
| - private static CompilerConfiguration config(final boolean incremental) { |
| + private static CompilerConfiguration config(final boolean incremental, final boolean checked) { |
| return new DefaultCompilerConfiguration() { |
| @Override |
| public boolean incremental() { |
| return incremental; |
| } |
| + |
| + @Override |
| + public boolean shouldWarnOnNoSuchType() { |
| + return true; |
| + } |
| + |
| + @Override |
| + public boolean developerModeChecks() { |
| + return checked; |
| + } |
| }; |
| } |
| @@ -222,9 +240,13 @@ public class CompileService { |
| private final LibrarySource runtimeLibrary; |
| - private CompileService(ThreadSafeArtifacts artifactCache, LibrarySource runtimeLibrary) { |
| + private final boolean useCheckedMode; |
| + |
| + private CompileService(ThreadSafeArtifacts artifactCache, LibrarySource runtimeLibrary, |
| + boolean useCheckedMode) { |
| this.artifactCache = artifactCache; |
| this.runtimeLibrary = runtimeLibrary; |
| + this.useCheckedMode = useCheckedMode; |
| } |
| public CompileResult build(File appFile) { |
| @@ -260,7 +282,7 @@ public class CompileService { |
| final long startedAt = System.currentTimeMillis(); |
| try { |
| DartCompiler.compileLib(source, |
| - config(true), |
| + config(true, useCheckedMode), |
| artifacts, |
| listener); |
| return new CompileResult(artifacts.getJavaScriptFor(source), |