Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8360030: Disable a PPAPI crash test under Valgrind. (Closed)

Created:
9 years, 2 months ago by Evgeniy Stepanov
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disable a PPAPI crash test under Valgrind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107110

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/native_client/tests/ppapi_browser/bad/nacl.scons View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Evgeniy Stepanov
9 years, 2 months ago (2011-10-21 14:34:55 UTC) #1
Nick Bray
LGTM w/ comment. http://codereview.chromium.org/8360030/diff/1/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons File ppapi/native_client/tests/ppapi_browser/bad/nacl.scons (right): http://codereview.chromium.org/8360030/diff/1/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons#newcode75 ppapi/native_client/tests/ppapi_browser/bad/nacl.scons:75: env.Bit('running_on_valgrind')) Why? Please add a comment.
9 years, 2 months ago (2011-10-21 17:06:21 UTC) #2
Evgeniy Stepanov
On 2011/10/21 17:06:21, Nick Bray wrote: > LGTM w/ comment. > > http://codereview.chromium.org/8360030/diff/1/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons > File ...
9 years, 2 months ago (2011-10-24 12:07:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@google.com/8360030/5001
9 years, 2 months ago (2011-10-24 12:07:56 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-24 13:11:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eugenis@google.com/8360030/5001
9 years, 2 months ago (2011-10-25 12:33:29 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 13:53:25 UTC) #7
Change committed as 107110

Powered by Google App Engine
This is Rietveld 408576698