Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

Issue 8360030: Disable a PPAPI crash test under Valgrind. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # -*- python -*- 1 # -*- python -*-
2 # Copyright (c) 2011 The Native Client Authors. All rights reserved. 2 # Copyright (c) 2011 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 # 5 #
6 # Tests fatal errors that occur during loading. 6 # Tests fatal errors that occur during loading.
7 # (See ppapi_browser/crash for fatal errors that occur after loading). 7 # (See ppapi_browser/crash for fatal errors that occur after loading).
8 # TODO(polina): rename the directory and browser test to bad_load 8 # TODO(polina): rename the directory and browser test to bad_load
9 # 9 #
10 # Manual testing with localhost:5103/scons-out/.../staging/ppapi_bad.html: 10 # Manual testing with localhost:5103/scons-out/.../staging/ppapi_bad.html:
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 nmfs=nmfs, 64 nmfs=nmfs,
65 files=[env.File(f) for f in ppapi_bad_files], 65 files=[env.File(f) for f in ppapi_bad_files],
66 args=['--allow_404']) 66 args=['--allow_404'])
67 67
68 # This test is failing on Windows: 68 # This test is failing on Windows:
69 # crbug.com/98720 69 # crbug.com/98720
70 env.AddNodeToTestSuite(node, 70 env.AddNodeToTestSuite(node,
71 ['chrome_browser_tests'], 71 ['chrome_browser_tests'],
72 'run_ppapi_bad_browser_test', 72 'run_ppapi_bad_browser_test',
73 is_broken=env.PPAPIBrowserTesterIsBroken() or 73 is_broken=env.PPAPIBrowserTesterIsBroken() or
74 env.Bit('host_windows')) 74 env.Bit('host_windows') or
75 env.Bit('running_on_valgrind'))
Nick Bray 2011/10/21 17:06:21 Why? Please add a comment.
75 76
76 77
77 # Bad nexe tests that won't work in PNaCl (native) 78 # Bad nexe tests that won't work in PNaCl (native)
78 # For example, partly_invalid.nexe has inline assembly in its source files. 79 # For example, partly_invalid.nexe has inline assembly in its source files.
79 nacltest_js = env.File('${SCONSTRUCT_DIR}/tools/browser_tester/browserdata/' + 80 nacltest_js = env.File('${SCONSTRUCT_DIR}/tools/browser_tester/browserdata/' +
80 'nacltest.js') 81 'nacltest.js')
81 partly_invalid = env.File('${STAGING_DIR}/partly_invalid${PROGSUFFIX}') 82 partly_invalid = env.File('${STAGING_DIR}/partly_invalid${PROGSUFFIX}')
82 nmf = '${TEST_DIR}/partly_invalid.nmf' 83 nmf = '${TEST_DIR}/partly_invalid.nmf'
83 if not env.Bit('nacl_glibc'): 84 if not env.Bit('nacl_glibc'):
84 ppapi_bad_native_files = [ 85 ppapi_bad_native_files = [
(...skipping 29 matching lines...) Expand all
114 'golden': '${TEST_DIR}/ppapi_bad_native_glibc.stderr'} 115 'golden': '${TEST_DIR}/ppapi_bad_native_glibc.stderr'}
115 ) 116 )
116 117
117 env.AddNodeToTestSuite(node, 118 env.AddNodeToTestSuite(node,
118 ['chrome_browser_tests'], 119 ['chrome_browser_tests'],
119 'run_ppapi_bad_native_test', 120 'run_ppapi_bad_native_test',
120 is_broken=env.PPAPIBrowserTesterIsBroken() or 121 is_broken=env.PPAPIBrowserTesterIsBroken() or
121 env.Bit('bitcode')) 122 env.Bit('bitcode'))
122 123
123 124
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698