Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

Issue 8360030: Disable a PPAPI crash test under Valgrind. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_browser/bad/nacl.scons
===================================================================
--- ppapi/native_client/tests/ppapi_browser/bad/nacl.scons (revision 106715)
+++ ppapi/native_client/tests/ppapi_browser/bad/nacl.scons (working copy)
@@ -67,11 +67,13 @@
# This test is failing on Windows:
# crbug.com/98720
+# This test is failing on Valgrind because of multiple nexes.
env.AddNodeToTestSuite(node,
['chrome_browser_tests'],
'run_ppapi_bad_browser_test',
is_broken=env.PPAPIBrowserTesterIsBroken() or
- env.Bit('host_windows'))
+ env.Bit('host_windows') or
+ env.Bit('running_on_valgrind'))
# Bad nexe tests that won't work in PNaCl (native)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698