Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 8354008: Fixing some warning due to different signess of char (Closed)

Created:
9 years, 2 months ago by Kristian Monsen
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org, tfarina
Visibility:
Public.

Description

Fixing some warning due to different signess of char BUG=None TEST=None Review URL: http://codereview.chromium.org/8354008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110968

Patch Set 1 #

Patch Set 2 : Updated with review url #

Patch Set 3 : Squashed commits #

Patch Set 4 : Better if in dns_util.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M base/string_split.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M net/base/dns_util.cc View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Kristian Monsen
9 years, 2 months ago (2011-10-19 17:32:41 UTC) #1
Kristian Monsen
On 2011/10/19 17:32:41, kristianm1 wrote: A quick ping. It's a small fix, but they are ...
9 years, 1 month ago (2011-11-18 11:53:35 UTC) #2
agl
LGTM.
9 years, 1 month ago (2011-11-18 15:32:04 UTC) #3
tfarina
On 2011/11/18 15:32:04, agl wrote: > LGTM. If you try to commit this through the ...
9 years, 1 month ago (2011-11-18 15:41:50 UTC) #4
Kristian Monsen
Added thakis for base owners
9 years, 1 month ago (2011-11-21 14:49:27 UTC) #5
Nico
lgtm
9 years, 1 month ago (2011-11-21 16:11:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/8354008/8001
9 years, 1 month ago (2011-11-21 16:11:21 UTC) #7
commit-bot: I haz the power
Presubmit check for 8354008-8001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 16:11:23 UTC) #8
Nico
+willchan for net/OWNERShip
9 years, 1 month ago (2011-11-21 16:23:31 UTC) #9
willchan no longer on Chromium
lgtm
9 years, 1 month ago (2011-11-21 16:55:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kristianm@chromium.org/8354008/8001
9 years, 1 month ago (2011-11-21 16:55:57 UTC) #11
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 19:02:55 UTC) #12
Change committed as 110968

Powered by Google App Engine
This is Rietveld 408576698