Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/dns_util.cc

Issue 8354008: Fixing some warning due to different signess of char (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Better if in dns_util.cc Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_split.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/dns_util.cc
diff --git a/net/base/dns_util.cc b/net/base/dns_util.cc
index 8051ca1ede10ea7dd1fc72dc55f81baca18c843d..93d789e31a22d17159cd81b75760f492f0336672 100644
--- a/net/base/dns_util.cc
+++ b/net/base/dns_util.cc
@@ -60,7 +60,11 @@ std::string DNSDomainToString(const std::string& domain) {
std::string ret;
for (unsigned i = 0; i < domain.size() && domain[i]; i += domain[i] + 1) {
- if (domain[i] < 0 || domain[i] > 63)
+#if CHAR_MIN < 0
+ if (domain[i] < 0)
+ return "";
+#endif
+ if (domain[i] > 63)
return "";
if (i)
« no previous file with comments | « base/string_split.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698