Issue 8345026: Prevent crash on unrecoverable error method call on FrontendDataTypeControllers.

Issue 8345026: Prevent crash on unrecoverable error method call on FrontendDataTypeControllers. (Closed)

Created:
9 years, 2 months ago by lipalani1

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea, tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Prevent crash by posting a task to call unrecoverable error handler. The task is posted on a weak pointer to PSS so as to prevent crashes on shut down. BUG=100698 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106373

Patch Set 1 #

Patch Set 2 : For review. #

Patch Set 3 : For review. #

Total comments: 2

Patch Set 4 : Upload before commit. #

Patch Set 5 : Upload before commit. #

Patch Set 6 : Upload before commit. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -3 lines)			Patch
M	chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc	View	1 2 3 4 5	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/extension_data_type_controller_unittest.cc	View	1 2 3 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/frontend_data_type_controller.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc	View	1 2 3 4	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/preference_data_type_controller_unittest.cc	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/theme_data_type_controller_unittest.cc	View	1 2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 2 3 4 5	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM with comment addressed and tests fixed. http://codereview.chromium.org/8345026/diff/4001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/8345026/diff/4001/chrome/browser/sync/profile_sync_service.h#newcode109 chrome/browser/sync/profile_sync_service.h:109: public base::SupportsWeakPtr<ProfileSyncService> ...

9 years, 2 months ago (2011-10-19 00:16:15 UTC) #2

lipalani1

filed 100829 and added it to the todo. running try jobs now. Thanks! http://codereview.chromium.org/8345026/diff/4001/chrome/browser/sync/profile_sync_service.h File ...

9 years, 2 months ago (2011-10-19 00:44:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/8345026/1004

9 years, 2 months ago (2011-10-19 05:57:44 UTC) #4

commit-bot: I haz the power

Can't apply patch for file chrome/browser/sync/profile_sync_service.h. While running patch -p1 --forward --force; patching file chrome/browser/sync/profile_sync_service.h ...

9 years, 2 months ago (2011-10-19 05:57:52 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/8345026/8001

9 years, 2 months ago (2011-10-19 18:28:03 UTC) #6

Change committed as 106373

Expand Messages | Collapse Messages