Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3734)

Unified Diff: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

Issue 8345026: Prevent crash on unrecoverable error method call on FrontendDataTypeControllers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Upload before commit. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extension_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
index d8a3fa9f10cb6a2f0e8695fd6711e8d61b13b69e..1e7fa57677d8c61193cddba2152ea9e5e1941eda 100644
--- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
@@ -90,6 +90,10 @@ class BookmarkDataTypeControllerTest : public testing::Test {
ModelAssociatorMock* model_associator_;
ChangeProcessorMock* change_processor_;
StartCallback start_callback_;
+
+ void PumpLoop() {
+ message_loop_.RunAllPending();
+ }
};
TEST_F(BookmarkDataTypeControllerTest, StartBookmarkModelReady) {
@@ -217,4 +221,5 @@ TEST_F(BookmarkDataTypeControllerTest, OnUnrecoverableError) {
bookmark_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));
// This should cause bookmark_dtc_->Stop() to be called.
bookmark_dtc_->OnUnrecoverableError(FROM_HERE, "Test");
+ PumpLoop();
}
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extension_data_type_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698