Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: chrome/browser/sync/glue/theme_data_type_controller_unittest.cc

Issue 8345026: Prevent crash on unrecoverable error method call on FrontendDataTypeControllers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Upload before commit. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc b/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
index 9b14ee11fc13d75fa1f4664cc7822bea4bb3a1d2..247fb6d7fead7552ae3b350f3b3a1744b86ca38c 100644
--- a/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc
@@ -67,6 +67,10 @@ class ThemeDataTypeControllerTest : public testing::Test {
EXPECT_CALL(*model_associator_, DisassociateModels(_));
}
+ void PumpLoop() {
+ message_loop_.RunAllPending();
+ }
+
MessageLoopForUI message_loop_;
BrowserThread ui_thread_;
scoped_refptr<ThemeDataTypeController> theme_dtc_;
@@ -165,4 +169,5 @@ TEST_F(ThemeDataTypeControllerTest, OnUnrecoverableError) {
theme_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));
// This should cause theme_dtc_->Stop() to be called.
theme_dtc_->OnUnrecoverableError(FROM_HERE, "Test");
+ PumpLoop();
}
« no previous file with comments | « chrome/browser/sync/glue/preference_data_type_controller_unittest.cc ('k') | chrome/browser/sync/profile_sync_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698