TaskManager: allows referencing task resources from the web ui.

TaskManager: allows referencing task resources from the web ui.

BUG=102075
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107740

[yurys, 2011-10-28 14:24:03]

On 2011/10/28 14:04:00, pfeldman wrote:

lgtm

[yoshiki, 2011-10-28 14:39:35]

LGTM with nit.

(Reviewers may be not Yoshifumi but me, so I reviewed)

http://codereview.chromium.org/8343060/diff/1/chrome/browser/task_manager/tas...
File chrome/browser/task_manager/task_manager.h (right):

http://codereview.chromium.org/8343060/diff/1/chrome/browser/task_manager/tas...
chrome/browser/task_manager/task_manager.h:142: int unique_id_;
Could you initialize unique_id_ on constructor? I think we should indicate that
unique_id has not been assigned.

[pfeldman1, 2011-10-28 14:51:54]

On 2011/10/28 14:39:35, yoshiki wrote:
> LGTM with nit.

> Could you initialize unique_id_ on constructor? I think we should indicate
that
> unique_id has not been assigned.

Sure, sorry for this oversight. I was sure I initialized it.

[commit-bot: I haz the power, 2011-10-28 15:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/8343060/3002

[commit-bot: I haz the power, 2011-10-28 16:29:00]

Change committed as 107740