TaskManager: allows referencing task resources from the web ui.

chrome/browser/ui/webui/task_manager_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/task_manager_handler.h"
 
 #include <algorithm>
 #include <functional>
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/task_manager/task_manager.h"
 #include "chrome/browser/ui/webui/web_ui_util.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "webkit/glue/webpreferences.h"
 
 namespace {
 
 static Value* CreateColumnValue(const TaskManagerModel* tm,
                                 const std::string column_name,
                                 const int i) {
-  if (column_name == "resourceIndex")
-    return Value::CreateIntegerValue(i);
+  if (column_name == "uniqueId")
+    return Value::CreateIntegerValue(tm->GetResourceUniqueId(i));
   if (column_name == "type")
     return Value::CreateStringValue(
         TaskManager::Resource::GetResourceTypeAsString(
         tm->GetResourceType(i)));
   if (column_name == "processId")
     return Value::CreateStringValue(tm->GetResourceProcessId(i));
   if (column_name == "processIdValue")
     return Value::CreateIntegerValue(tm->GetProcessId(i));
   if (column_name == "cpuUsage")
     return Value::CreateStringValue(tm->GetResourceCPUUsage(i));
@@ skipping 130 matching lines @@
   CreateGroupColumnList(tm, "webCoreScriptsCacheSize", index, 1, val);
   CreateGroupColumnList(tm, "webCoreScriptsCacheSizeValue", index, 1, val);
   CreateGroupColumnList(tm, "webCoreCSSCacheSize", index, 1, val);
   CreateGroupColumnList(tm, "webCoreCSSCacheSizeValue", index, 1, val);
   CreateGroupColumnList(tm, "sqliteMemoryUsed", index, 1, val);
   CreateGroupColumnList(tm, "sqliteMemoryUsedValue", index, 1, val);
   CreateGroupColumnList(tm, "v8MemoryAllocatedSize", index, 1, val);
   CreateGroupColumnList(tm, "v8MemoryAllocatedSizeValue", index, 1, val);
 
   // Columns which have some data in each group.
-  CreateGroupColumnList(tm, "resourceIndex", index, length, val);
+  CreateGroupColumnList(tm, "uniqueId", index, length, val);
   CreateGroupColumnList(tm, "icon", index, length, val);
   CreateGroupColumnList(tm, "title", index, length, val);
   CreateGroupColumnList(tm, "profileName", index, length, val);
   CreateGroupColumnList(tm, "networkUsage", index, length, val);
   CreateGroupColumnList(tm, "networkUsageValue", index, length, val);
   CreateGroupColumnList(tm, "fps", index, length, val);
   CreateGroupColumnList(tm, "fpsValue", index, length, val);
   CreateGroupColumnList(tm, "goatsTeleported", index, length, val);
   CreateGroupColumnList(tm, "goatsTeleportedValue", index, length, val);
   CreateGroupColumnList(tm, "canInspect", index, length, val);
@@ skipping 155 matching lines @@
       continue;
 
     LOG(INFO) << "kill PID:" << model_->GetResourceProcessId(resource_index);
     task_manager_->KillProcess(resource_index);
   }
 }
 
 void TaskManagerHandler::HandleInspect(const ListValue* resource_index) {
   for (ListValue::const_iterator i = resource_index->begin();
        i != resource_index->end(); ++i) {
-    int resource_index = parseIndex(*i);
-    if (resource_index == -1)
+    int unique_id = parseIndex(*i);
+    if (unique_id == -1)
       continue;
-    if (model_->CanInspect(resource_index))
-      model_->Inspect(resource_index);
+
+    for (int resource_index = 0; resource_index < model_->ResourceCount();
+         ++resource_index) {
+      if (model_->GetResourceUniqueId(resource_index) == unique_id) {
+        if (model_->CanInspect(resource_index))
+          model_->Inspect(resource_index);
+        break;
+      }
+    }
+
     break;
   }
 }
 
 void TaskManagerHandler::DisableTaskManager(const ListValue* indexes) {
   if (!is_enabled_)
     return;
 
   is_enabled_ = false;
   model_->StopUpdating();
@@ skipping 78 matching lines @@
   }
 }
 
 void TaskManagerHandler::OnGroupRemoved(const int group_start,
                                         const int group_length) {
   base::FundamentalValue start_value(group_start);
   base::FundamentalValue length_value(group_length);
   if (is_enabled_ && is_alive())
     web_ui_->CallJavascriptFunction("taskRemoved", start_value, length_value);
 }