Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 8343060: TaskManager: allows referencing task resources from the web ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments addressed. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/webui/task_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 7b7cad2de19bd5d537f48276f7c8ac24124cba7e..6607d8e03746f97bc45d949ab711d0e345d9c782 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -78,7 +78,8 @@ string16 FormatStatsSize(const WebKit::WebCache::ResourceTypeStat& stat) {
TaskManagerModel::TaskManagerModel(TaskManager* task_manager)
: update_requests_(0),
update_state_(IDLE),
- goat_salt_(rand()) {
+ goat_salt_(rand()),
+ last_unique_id_(0) {
AddResourceProvider(
new TaskManagerBrowserProcessResourceProvider(task_manager));
AddResourceProvider(
@@ -118,6 +119,11 @@ void TaskManagerModel::RemoveObserver(TaskManagerModelObserver* observer) {
observer_list_.RemoveObserver(observer);
}
+int TaskManagerModel::GetResourceUniqueId(int index) const {
+ CHECK_LT(index, ResourceCount());
+ return resources_[index]->get_unique_id();
+}
+
string16 TaskManagerModel::GetResourceTitle(int index) const {
CHECK_LT(index, ResourceCount());
return resources_[index]->GetTitle();
@@ -561,10 +567,12 @@ bool TaskManagerModel::GetV8Memory(int index, size_t* result) const {
}
bool TaskManagerModel::CanInspect(int index) const {
+ CHECK_LT(index, ResourceCount());
return resources_[index]->CanInspect();
}
void TaskManagerModel::Inspect(int index) const {
+ CHECK_LT(index, ResourceCount());
resources_[index]->Inspect();
}
@@ -642,6 +650,8 @@ void TaskManagerModel::AddResourceProvider(
}
void TaskManagerModel::AddResource(TaskManager::Resource* resource) {
+ resource->unique_id_ = ++last_unique_id_;
+
base::ProcessHandle process = resource->GetProcess();
ResourceList* group_entries = NULL;
@@ -767,6 +777,7 @@ void TaskManagerModel::Clear() {
FOR_EACH_OBSERVER(TaskManagerModelObserver, observer_list_,
OnItemsRemoved(0, size));
}
+ last_unique_id_ = 0;
}
void TaskManagerModel::ModelChanged() {
« no previous file with comments | « chrome/browser/task_manager/task_manager.h ('k') | chrome/browser/ui/webui/task_manager_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698