Issue 8343043: Allow off the record dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8343043: Allow off the record dialogs (Closed)

Created:
9 years, 1 month ago by Albert Bodenhamer

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, Scott Byer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Allow off the record dialogs Modify dialog creation flow to allow an off the record profile to be used in an html dialog. Fixes issues with cloud print where the signed-in state of the page and dialogs are out of sync. Adds DCHECKS that fire if a non-modal dialog is created with an off the record profile. This provides a temporary solution to sign-in issues on most platforms. A longer term solution is in the works to eliminate our dependency on html dialog. BUG=99271 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108027

Patch Set 1 #

Patch Set 2 : Fix build break on Mac #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
M	chrome/browser/ui/cocoa/html_dialog_window_controller.mm	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/html_dialog_gtk.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/html_dialog_view.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM in cocoa as a temporary thing. I only reviewed the file in cocoa.

9 years, 1 month ago (2011-10-28 19:19:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8343043/6

9 years, 1 month ago (2011-10-31 21:32:33 UTC) #4

Change committed as 108027

Expand Messages | Collapse Messages