chrome/browser/ui/gtk/html_dialog_gtk.cc - Issue 8343043: Allow off the record dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/html_dialog_gtk.cc

Issue 8343043: Allow off the record dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix build break on Mac Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/html_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/html_dialog_gtk.cc b/chrome/browser/ui/gtk/html_dialog_gtk.cc

index f2b28842be6080333b5e530d300a224ebbcc757f..ff6945a9d6a4fc7e5c629701f978f4449594f104 100644

--- a/chrome/browser/ui/gtk/html_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/html_dialog_gtk.cc

@@ -22,6 +22,10 @@ namespace browser {

gfx::NativeWindow ShowHtmlDialog(gfx::NativeWindow parent, Profile* profile,

HtmlDialogUIDelegate* delegate) {

+ // It's not always safe to display an html dialog with an off the record

+ // profile. If the last browser with that profile is closed it will go

+ // away.

+ DCHECK(!profile->IsOffTheRecord() || delegate->IsDialogModal());

HtmlDialogGtk* html_dialog =

new HtmlDialogGtk(profile, delegate, parent);

return html_dialog->InitDialog();