Allow off the record dialogs

chrome/browser/ui/cocoa/html_dialog_window_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/html_dialog_window_controller.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 60 matching lines @@
 
 // BrowserCommandExecutor methods.
 - (void)executeCommand:(int)command;
 
 @end
 
 namespace browser {
 
 gfx::NativeWindow ShowHtmlDialog(gfx::NativeWindow parent, Profile* profile,
                                  HtmlDialogUIDelegate* delegate) {
+  // It's not always safe to display an html dialog with an off the record
+  // profile.  If the last browser with that profile is closed it will go
+  // away.
+  // On most platforms we insist on the dialog being modal if we're off the
+  // record to prevent that.  That wont work on the Mac since we don't have
+  // modal dialogs.
+  // Fall back to the old (incorrect) behavior of grabbing the original
+  // profile.
   // NOTE: Use the parent parameter once we implement modal dialogs.
-  return [HtmlDialogWindowController showHtmlDialog:delegate profile:profile];
+  return [HtmlDialogWindowController showHtmlDialog:delegate
+      profile:profile->GetOriginalProfile()];
 }
 
 }  // namespace html_dialog_window_controller
 
 HtmlDialogWindowDelegateBridge::HtmlDialogWindowDelegateBridge(
     HtmlDialogWindowController* controller, Profile* profile,
     HtmlDialogUIDelegate* delegate)
     : HtmlDialogTabContentsDelegate(profile),
       controller_(controller), delegate_(delegate) {
   DCHECK(controller_);
@@ skipping 203 matching lines @@
   // TODO(akalin): Figure out why implementing (void)cancel:(id)sender
   // to do the above doesn't work.
 }
 
 - (void)windowWillClose:(NSNotification*)notification {
   delegate_->WindowControllerClosed();
   [self autorelease];
 }
 
 @end