Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed)

Created:
9 years, 2 months ago by jam
Modified:
9 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Visibility:
Public.

Description

Make NotificationService an interface in the content namespace, and switch callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106403

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1754 lines, -2057 lines) Patch
M chrome/browser/accessibility/accessibility_win_browsertest.cc View 1 2 3 4 19 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/accessibility/renderer_accessibility_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/accessibility_events.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/automation/automation_extension_tracker.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 30 chunks +55 lines, -53 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers_chromeos.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_service_filter.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/cros/login_library.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_manager_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ownership_service_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/profile_image_downloader.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/proxy_settings_dialog.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/session_manager_observer.cc View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 2 3 4 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/views_oobe_display.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/balloon_collection_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/notifications/notification_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/take_photo_dialog.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_browsertest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/memory_menu_button.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/tab_closeable_state_watcher.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/user_cros_settings_provider.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/web_socket_proxy_controller.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/wm_ipc.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/mock_settings_observer.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 2 3 4 6 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 2 3 4 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/apps_promo.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_action_apitest.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.cc View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_app_api.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_browser_actions_api.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 4 10 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 4 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_input_method_apitest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_menu_manager.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_menu_manager_unittest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_metrics_apitest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_navigation_observer.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_api.cc View 1 2 3 4 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_apitest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_permissions_api.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_permissions_api.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_save_page_api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 13 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_settings_frontend_unittest.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tab_id_map.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_test_api.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_test_message_listener.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_warning_set.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_web_socket_proxy_private_api.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_apitest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_apitest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_extension_loader.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/image_loading_tracker.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/image_loading_tracker_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/network_delay_listener.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/network_delay_listener_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/speech_input/extension_speech_input_api.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/speech_input/extension_speech_input_api.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/speech_input/extension_speech_input_manager.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 3 4 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/history.cc View 1 2 3 4 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites.cc View 1 2 3 4 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/importer/profile_writer.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 1 2 3 4 9 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_purger.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/metrics/metrics_service_uitest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/gaia/token_service.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/oom_priority_manager.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/oom_priority_manager_browsertest.cc View 1 2 3 4 5 6 3 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_data_remover_helper.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_prefs.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_notifier_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_notifier_impl_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_uitest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_model.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 2 3 4 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/remoting/firewall_traversal_observer.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/remoting/firewall_traversal_observer_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/web_cache_manager.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_history.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/restore_tab_helper.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 4 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sidebar/sidebar_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 7 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_mock.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_test_util.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/signin_manager.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor_unittest.cc View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 2 3 4 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/chrome_interstitial_page.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/pinned_tab_service.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_notification_resource_provider.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 9 chunks +50 lines, -38 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_tab_helper.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 10 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 14 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 3 4 9 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 16 chunks +32 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller_unittest.mm View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/theme_install_bubble_view.mm View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_tab_helper.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/global_error_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_menu_bar.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/overflow_button.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/theme_install_bubble_view_gtk.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 2 3 4 5 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/dom_view_browsertest.cc View 1 2 3 4 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/file_manager_dialog_browsertest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/theme_install_bubble_view.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_proxy.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/metrics_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/bookmarks_handler.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/user_style_sheet_watcher.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_event_listener.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 2 3 4 16 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_database.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/test_html_dialog_observer.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 3 4 10 chunks +11 lines, -9 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/test_navigation_observer.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_main.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_process_sub_thread.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/cert_store.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/debugger/render_view_devtools_agent_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/host_zoom_map.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/mach_broker_mac.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/notification_service_impl.h View 1 2 3 4 2 chunks +11 lines, -51 lines 0 comments Download
A + content/browser/notification_service_impl.cc View 4 chunks +18 lines, -12 lines 0 comments Download
A + content/browser/notification_service_impl_unittest.cc View 13 chunks +21 lines, -19 lines 0 comments Download
M content/browser/plugin_service.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 2 3 4 8 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/site_instance.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 3 4 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 12 chunks +19 lines, -19 lines 0 comments Download
M content/browser/user_metrics.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/child_thread.h View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M content/common/child_thread.cc View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
D content/common/notification_service.h View 1 2 3 4 1 chunk +0 lines, -132 lines 0 comments Download
D content/common/notification_service.cc View 1 2 3 4 1 chunk +0 lines, -141 lines 0 comments Download
D content/common/notification_service_unittest.cc View 1 2 3 4 1 chunk +0 lines, -165 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
A content/public/browser/DEPS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/notification_registrar.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
A content/public/browser/notification_service.h View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/test/content_test_suite.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/test_notification_tracker.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
(ignore the watchlist change, that was just to get it to upload and I've reverted ...
9 years, 2 months ago (2011-10-19 19:40:03 UTC) #1
Avi (use Gerrit)
9 years, 2 months ago (2011-10-19 21:49:18 UTC) #2 
As requested, review of notification_service* and child_thread*. LGTM with nits.

http://codereview.chromium.org/8342048/diff/7945/content/browser/notification...
File content/browser/notification_service_impl.h (right):

http://codereview.chromium.org/8342048/diff/7945/content/browser/notification...
content/browser/notification_service_impl.h:5: #ifndef
CONTENT_PUBLIC_BRWOSER_NOTIFICATION_SERVICE_IMPL_H_
typo

http://codereview.chromium.org/8342048/diff/7945/content/public/browser/notif...
File content/public/browser/notification_service.h (right):

http://codereview.chromium.org/8342048/diff/7945/content/public/browser/notif...
content/public/browser/notification_service.h:37: const NotificationDetails&
details) = 0;
alignment

Powered by Google App Engine
This is Rietveld 408576698