Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5299)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
===================================================================
--- chrome/browser/extensions/crx_installer.cc (revision 106380)
+++ chrome/browser/extensions/crx_installer.cc (working copy)
@@ -34,7 +34,7 @@
#include "chrome/common/extensions/extension_file_util.h"
#include "content/browser/browser_thread.h"
#include "content/browser/user_metrics.h"
-#include "content/common/notification_service.h"
+#include "content/public/browser/notification_service.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
@@ -444,10 +444,11 @@
extension_, histogram_name.c_str());
// Kill the theme loading bubble.
- NotificationService* service = NotificationService::current();
+ content::NotificationService* service =
+ content::NotificationService::current();
service->Notify(chrome::NOTIFICATION_NO_THEME_DETECTED,
content::Source<CrxInstaller>(this),
- NotificationService::NoDetails());
+ content::NotificationService::NoDetails());
Release(); // balanced in ConfirmInstall().
NotifyCrxInstallComplete();
@@ -518,7 +519,8 @@
void CrxInstaller::ReportFailureFromUIThread(const std::string& error) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- NotificationService* service = NotificationService::current();
+ content::NotificationService* service =
+ content::NotificationService::current();
service->Notify(chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR,
content::Source<CrxInstaller>(this),
content::Details<const std::string>(&error));
@@ -594,8 +596,8 @@
// is problematic because they don't know anything about the
// extension before it is unpacked, so they can not filter based
// on the extension.
- NotificationService::current()->Notify(
+ content::NotificationService::current()->Notify(
chrome::NOTIFICATION_CRX_INSTALLER_DONE,
content::Source<CrxInstaller>(this),
- NotificationService::NoDetails());
+ content::NotificationService::NoDetails());
}
« no previous file with comments | « chrome/browser/extensions/convert_web_app_browsertest.cc ('k') | chrome/browser/extensions/execute_code_in_tab_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698