Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: chrome/browser/oom_priority_manager_browsertest.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/oom_priority_manager.cc ('k') | chrome/browser/password_manager/password_store_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/oom_priority_manager_browsertest.cc
===================================================================
--- chrome/browser/oom_priority_manager_browsertest.cc (revision 106380)
+++ chrome/browser/oom_priority_manager_browsertest.cc (working copy)
@@ -8,6 +8,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "googleurl/src/gurl.h"
@@ -20,21 +21,24 @@
using namespace ui_test_utils;
// Get three tabs open. Load asynchronously to speed up the test.
- WindowedNotificationObserver load1(content::NOTIFICATION_LOAD_STOP,
- NotificationService::AllSources());
+ WindowedNotificationObserver load1(
+ content::NOTIFICATION_LOAD_STOP,
+ content::NotificationService::AllSources());
OpenURLParams open1(GURL("chrome://about"), GURL(),
CURRENT_TAB, content::PAGE_TRANSITION_TYPED, false);
browser()->OpenURL(open1);
- WindowedNotificationObserver load2(content::NOTIFICATION_LOAD_STOP,
- NotificationService::AllSources());
+ WindowedNotificationObserver load2(
+ content::NOTIFICATION_LOAD_STOP,
+ content::NotificationService::AllSources());
OpenURLParams open2(GURL("chrome://credits"), GURL(),
NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED,
false);
browser()->OpenURL(open2);
- WindowedNotificationObserver load3(content::NOTIFICATION_LOAD_STOP,
- NotificationService::AllSources());
+ WindowedNotificationObserver load3(
+ content::NOTIFICATION_LOAD_STOP,
+ content::NotificationService::AllSources());
OpenURLParams open3(GURL("chrome://terms"), GURL(),
NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED,
false);
@@ -71,8 +75,9 @@
EXPECT_FALSE(g_browser_process->oom_priority_manager()->DiscardTab());
// Select the first tab. It should reload.
- WindowedNotificationObserver reload1(content::NOTIFICATION_LOAD_STOP,
- NotificationService::AllSources());
+ WindowedNotificationObserver reload1(
+ content::NOTIFICATION_LOAD_STOP,
+ content::NotificationService::AllSources());
browser()->SelectNumberedTab(0);
reload1.Wait();
EXPECT_FALSE(browser()->IsTabDiscarded(0));
« no previous file with comments | « chrome/browser/oom_priority_manager.cc ('k') | chrome/browser/password_manager/password_store_default.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698