Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 8341094: Changed change processors to use ScopedStopObserving (Closed)

Created:
9 years, 1 month ago by Andrew T Wilson (Slow)
Modified:
9 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, GeorgeY, ncarter (slow), akalin, Raghu Simha, dyu1, Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Changed change processors to use ScopedStopObserving BUG=84918 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107989

Patch Set 1 #

Patch Set 2 : Fixed compilation errors. #

Patch Set 3 : Removed unnecessary call to StartObserving(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M chrome/browser/sync/glue/autofill_change_processor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrew T Wilson (Slow)
Just cleaning out some of my bug/cleanup backlog. This stuff probably goes away eventually when ...
9 years, 1 month ago (2011-10-28 01:15:53 UTC) #1
Nicolas Zea
LGTM
9 years, 1 month ago (2011-10-29 16:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/8341094/4001
9 years, 1 month ago (2011-10-31 17:09:54 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 19:13:11 UTC) #4
Change committed as 107989

Powered by Google App Engine
This is Rietveld 408576698