chrome/browser/sync/glue/theme_change_processor.cc - Issue 8341094: Changed change processors to use ScopedStopObserving

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/theme_change_processor.cc

Issue 8341094: Changed change processors to use ScopedStopObserving (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unnecessary call to StartObserving(). Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/theme_change_processor.cc

diff --git a/chrome/browser/sync/glue/theme_change_processor.cc b/chrome/browser/sync/glue/theme_change_processor.cc

index c32b26b5ab86286f7dbd074e2c7c865a8e06776b..6cd9341fd22c5d475e3f9e89acea5c390fc138a1 100644

--- a/chrome/browser/sync/glue/theme_change_processor.cc

+++ b/chrome/browser/sync/glue/theme_change_processor.cc

@@ -106,9 +106,8 @@ void ThemeChangeProcessor::ApplyChangesFromSyncModel(

DCHECK(profile_);

theme_specifics = node.GetThemeSpecifics();

}

- StopObserving();

+ ScopedStopObserving<ThemeChangeProcessor> stop_observing(this);

SetCurrentThemeFromThemeSpecificsIfNecessary(theme_specifics, profile_);

- StartObserving();

}

void ThemeChangeProcessor::StartImpl(Profile* profile) {