Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: chrome/browser/sync/glue/password_change_processor.cc

Issue 8341094: Changed change processors to use ScopedStopObserving (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed unnecessary call to StartObserving(). Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/password_change_processor.cc
diff --git a/chrome/browser/sync/glue/password_change_processor.cc b/chrome/browser/sync/glue/password_change_processor.cc
index 5022542f2db2b9375b836c7c2cd36ac01e220cfb..9aae52d315c0f27619529c35865c6632af848b38 100644
--- a/chrome/browser/sync/glue/password_change_processor.cc
+++ b/chrome/browser/sync/glue/password_change_processor.cc
@@ -197,7 +197,7 @@ void PasswordChangeProcessor::CommitChangesFromSyncModel() {
DCHECK(expected_loop_ == MessageLoop::current());
if (!running())
return;
- StopObserving();
+ ScopedStopObserving<PasswordChangeProcessor> stop_observing(this);
if (!model_associator_->WriteToPasswordStore(&new_passwords_,
&updated_passwords_,
@@ -209,8 +209,6 @@ void PasswordChangeProcessor::CommitChangesFromSyncModel() {
deleted_passwords_.clear();
new_passwords_.clear();
updated_passwords_.clear();
-
- StartObserving();
}
void PasswordChangeProcessor::StartImpl(Profile* profile) {
« no previous file with comments | « chrome/browser/sync/glue/password_change_processor.h ('k') | chrome/browser/sync/glue/session_change_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698